-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wasm32 target support #141
Comments
All the tests need to be adapted to use wasm-bindgen-test. |
I think this is dependent on a few changes to ring and probably no changes to webpki:
Once the ring issues are addressed, I expect this issue will be reduced to:
|
@briansmith: This is an important feature for us. We would be willing to fund a bounty (i.e. gitcoin) to have this resolved. But we'd need an estimate of efforts |
Given a bit of research and digging into the issue, I believe it would be better to isolate dependency of |
At this point all that's left is testing wasm32-unknown-unknown targets to webpki's CI, correct? |
I think the wasm32-wasi testing in webpki's CI, in combination with the more thorough testing in ring's CI that includes wasm32-unknown-unknown in a browser, is enough. After all, there is no target-specific code in webpki. So I think we can close this. WDYT? |
I was just writing CI and realized similar, there is no (wasm-bindgen-test) target-specific testing to do. However a feature like Would you consider accepting a PR creating that specific feature + the modification to CI to exclude it from the matrix which now calls --all-features? Merely testing that wasm32-unknown-unknown builds would also be appropriate. |
We don't need this feature because you can just do this in your Cargo.toml:
Even if your application doesn't depend directly on ring, this is how you enable its features. Otherwise, if we add the feature you are proposing, then we create more maintenance work for ourselves within webpki, as we now have more configurations to support. |
That works for me. Thanks for the tip |
Thanks for the feedback. I'm going to close this now, as complete. |
No description provided.
The text was updated successfully, but these errors were encountered: