Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add u2f attestation support #57

Open
13 tasks
briansmith opened this issue Sep 11, 2017 · 3 comments
Open
13 tasks

Add u2f attestation support #57

briansmith opened this issue Sep 11, 2017 · 3 comments

Comments

@briansmith
Copy link
Owner

briansmith commented Sep 11, 2017

  • Add support for U2F trust anchors.
  • Make it easy to parse the u2f attestation certificate out of the U2F message.
  • Maybe add a workaround for the encoding issue described at Yubico U2F attestation cert with failing test #34 (comment).
  • Write documentation, including an example, about how to verify attestations.
  • Compare AAGUID from the certificate via the id-fido-gen-ce-aaguid extension and comparing it to the expected AAGUID.
  • Packed Attestation Certificates
    • Don't require a subjectAltName extension.
  • TPM Attestation Certificates
    • Subject must be empty
    • There must be a SAN as specified in the TPM specs.
    • EKU = "2.23.133.8.3" OID.
  • Android Attestation Certificates
    • dNSName = attest.android.com

AFAICT, Yubico's attestation certificates don't include any EKU or key usage fields. Presumably we shouldn't verify for an EKU and the key usage should be digitalSignature.

/cc @wisespace-io @robn

@briansmith
Copy link
Owner Author

@briansmith
Copy link
Owner Author

See also #40 (comment)

/cc @cmsd2

@targodan
Copy link

targodan commented Oct 2, 2019

Just wanted to poke at this.

Apparently this issue prevents me from using my YubiKey with bitwardenrs. See #bitwarden_rs/272

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants