Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sweep: Support Figma SMALL_CAPS and SMALL_CAPS_FORCED textCase #103

Open
wwzeng1 opened this issue Aug 8, 2023 · 1 comment
Open

Sweep: Support Figma SMALL_CAPS and SMALL_CAPS_FORCED textCase #103

wwzeng1 opened this issue Aug 8, 2023 · 1 comment
Labels
enhancement New feature or request sweep Assigns Sweep to an issue or pull request.

Comments

@wwzeng1
Copy link

wwzeng1 commented Aug 8, 2023

This can be implemented with the CSS font-variant-caps property.

Will need to change:

getStyledTextSegments() in core/src/design/adapter/figma/adapter.ts
getCssAttributes() in core/src/design/adapter/figma/adapter.ts

@wwzeng1 wwzeng1 added the enhancement New feature or request label Aug 8, 2023
@sweep-ai sweep-ai bot added the sweep Assigns Sweep to an issue or pull request. label Aug 8, 2023
@sweep-ai
Copy link

sweep-ai bot commented Aug 8, 2023

80%


❌ Unable to Complete PR

I'm sorry, but it looks like an error has occurred. Try changing the issue description to re-trigger Sweep. If this error persists contact team@sweep.dev.

For bonus GPT-4 tickets, please report this bug on Discord.


Please look at the generated plan. If something looks wrong, please add more details to your issue.

File Path Proposed Changes
core/src/design/adapter/figma/adapter.ts In the getStyledTextSegments() function, add a case for SMALL_CAPS and SMALL_CAPS_FORCED in the switch statement for textCase. Map these cases to the appropriate value for the CSS font-variant-caps property. In the getCssAttributes() function, add a case for font-variant-caps in the switch statement for cssAttribute. Map this case to the appropriate value for the CSS font-variant-caps property.

To recreate the pull request, leave a comment prefixed with "sweep:" or edit the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sweep Assigns Sweep to an issue or pull request.
Projects
None yet
Development

No branches or pull requests

1 participant