Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pools section droppable #1914

Closed
jameskerr opened this issue Nov 1, 2021 · 1 comment · Fixed by #1938
Closed

Make pools section droppable #1914

jameskerr opened this issue Nov 1, 2021 · 1 comment · Fixed by #1938
Assignees

Comments

@jameskerr
Copy link
Member

When I was creating a lot of new pools, it was annoying to have to click the plus button each time. I want to be able to drag the file right onto the pools section of the side bar and ingest it.

Make this droppable 👇
Screen Shot 2021-11-01 at 10 18 51 AM

@mattnibs
Copy link
Contributor

Verified that I get a lovely import animation when I drag a zson file into the pools section (Brim v0.28.0). I did notice that if I dropped that same zson file into the queries section, nothing happens in the app but I do get a console error:

image

Maybe there should be an error if you drop a bad file into the queries section? You do get an error if you drag a bad file into the pools section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants