Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hang on "Fetching" after adding a Time Range pin #2483

Closed
philrz opened this issue Aug 11, 2022 · 2 comments · Fixed by #2472
Closed

Hang on "Fetching" after adding a Time Range pin #2483

philrz opened this issue Aug 11, 2022 · 2 comments · Fixed by #2472
Labels
bug Something isn't working

Comments

@philrz
Copy link
Contributor

philrz commented Aug 11, 2022

Repro is with Brim commit 1ee21a8.

To repro:

  1. Import a test pcap (such as sample.pcap from this repo)
  2. Add a "Time Range" pin (accepting the default start/end times is fine)
  3. Execute the query

As shown in the video below, at this point it now hangs in "Fetching" status. A look in DevTools shows this stack dump when the query was executed:

13:57:23.670 › Security Warning: Prevented navigation to file:///Users/phil/work/brim/dialog?field=ts&from=2022-08-11T20%3A27%3A21.533Z&to=2022-08-11T20%3A57%3A21.533Z
consoleLog @ /Users/phil/work/brim/node_modules/electron-log/src/transports/console.js:91
transport @ /Users/phil/work/brim/node_modules/electron-log/src/transports/console.js:46
runTransport @ /Users/phil/work/brim/node_modules/electron-log/src/log.js:44
(anonymous) @ /Users/phil/work/brim/node_modules/electron-log/src/transports/ipc.js:21
emit @ node:events:394
onMessage @ node:electron/js2c/renderer_init:81

If I try to execute the query again, I get this different stack dump:

/Users/phil/work/brim/node_modules/history/cjs/history.js:871 Uncaught TypeError: Cannot assign to read only property '1' of object '[object Array]'
    at /Users/phil/work/brim/node_modules/history/cjs/history.js:871
    at Object.confirmTransitionTo (/Users/phil/work/brim/node_modules/history/cjs/history.js:168)
    at Object.replace (/Users/phil/work/brim/node_modules/history/cjs/history.js:869)
    at /Users/phil/work/brim/dist/app/router/tab-history.js:31
    at Object.dispatch (/Users/phil/work/brim/node_modules/redux-thunk/lib/index.js:11)
    at QueriesApi.dispatch (<anonymous>:3665:80)
    at QueriesApi.open (/Users/phil/work/brim/dist/js/api/queries/queries-api.js:97)
    at /Users/phil/work/brim/dist/app/query-home/flows/submit-search.js:35
    at Object.dispatch (/Users/phil/work/brim/node_modules/redux-thunk/lib/index.js:11)
    at dispatch (<anonymous>:3665:80)
Repro.mp4
@philrz philrz added the bug Something isn't working label Aug 11, 2022
@jameskerr
Copy link
Member

Got it. Thank you

@philrz
Copy link
Contributor Author

philrz commented Sep 1, 2022

Verified in Brim commit b08ceaf.

As shown in the attached video, now when the Time Range pin is added, the query re-executes as expected and we're now able to start manipulating the picker settings directly or by brushing the bar chart.

Verify.mp4

Thanks @jameskerr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants