Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"from" pin is dropped when saving query (regression at b08ceaf) #2528

Closed
philrz opened this issue Sep 9, 2022 · 1 comment · Fixed by #2529
Closed

"from" pin is dropped when saving query (regression at b08ceaf) #2528

philrz opened this issue Sep 9, 2022 · 1 comment · Fixed by #2529
Labels
bug Something isn't working

Comments

@philrz
Copy link
Contributor

philrz commented Sep 9, 2022

Repro is with Brim commit 9b2c9c4, though I've confirmed via binary search that this problem first showed up at commit b08ceaf, which is associated with the changes in #2472.

As shown in the attached video, when a "from" pin is present and the query is saved, the "from" pin is immediately dropped.

Repro.mp4
@philrz philrz added the bug Something isn't working label Sep 9, 2022
@jameskerr jameskerr mentioned this issue Sep 9, 2022
@philrz
Copy link
Contributor Author

philrz commented Sep 11, 2022

Verified in Brim commit 03322d0.

Repeating the repro steps as shown in the attached video, now the "from" pin remains intact when the query is saved.

Verify.mp4

Thanks @jameskerr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant