Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad clickable sorts with nested fields #2539

Closed
philrz opened this issue Sep 16, 2022 · 3 comments · Fixed by #2626
Closed

Bad clickable sorts with nested fields #2539

philrz opened this issue Sep 16, 2022 · 3 comments · Fixed by #2626
Labels
bug Something isn't working

Comments

@philrz
Copy link
Contributor

philrz commented Sep 16, 2022

Repro is with Brim commit 124d658.

As shown in the attached video, while clicking column headers on a top-level field still has the expected effect of appending sort or sort -r on the active query, if I attempt the same on a nested field like id.orig_h it seems like nothing happens. Also, if I right-click and select one of the sort options, the appended field name lacks the leading id and hence the data does not get sorted. These might be two different bugs but I'm starting them both in the same issue in the event they share a root cause or can otherwise be attacked together.

Repro.mp4
@philrz philrz added the bug Something isn't working label Sep 16, 2022
@jameskerr
Copy link
Member

Makes sense. I'll take this to account in my table rewrite.

@philrz
Copy link
Contributor Author

philrz commented Dec 29, 2022

This one is on track to be addressed by the changes in #2626.

The attached video shows how things are looking now at commit 4014451 of the branch from #2626. Now after invoking the new Expand Headers option, clicking the sort options in the header appends the correct Zed in the editor and the contents are sorted ascending/descending as expected.

BranchCheck.mp4

Other ways to invoke sort may be added as the PR progresses so I'll do a final verification when the changes merge, but looks 👍 right now.

@philrz philrz mentioned this issue Dec 29, 2022
45 tasks
@philrz
Copy link
Contributor Author

philrz commented Jan 26, 2023

Verified in Brim commit 499a2c9.

The attached video shows the multiple ways of now invoking sort by clicking directly on the value of a nested field in its expanded/collapsed state as well as by clicking in the column header. In all cases the syntactically correct Zed was appended and the sort was successful.

Verify.mp4

Thanks @jameskerr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants