Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve presentation of backend panic errors #2620

Open
philrz opened this issue Dec 14, 2022 · 0 comments
Open

Improve presentation of backend panic errors #2620

philrz opened this issue Dec 14, 2022 · 0 comments

Comments

@philrz
Copy link
Contributor

philrz commented Dec 14, 2022

Repro is with Brim 3d473b2 pointing at Zed commit db57e46 which is on the branch associated with brimdata/super#4264.

In a recent group discussion I expressed curiosity as to whether panics currently make their way all the way to the app user. As @mattnibs pointed out, the potential to overflow the stack with a UDF represents one of the easiest ways to trigger a panic, so I gave it a look.

The good news is that the panic is presented. Here's some example Zed to trigger it:

func overflow(n): (
  overflow(n+1)
)

from foo
| yield overflow(num)

If the "foo" pool is loaded with a single record {num: 3}, when the program runs we see:

image

Compare this with the stack from running the same at the CLI:

panic: stack overflow
goroutine 522 [running]:
runtime/debug.Stack()
	/usr/local/opt/go/libexec/src/runtime/debug/stack.go:24 +0x65
github.com/brimdata/zed/runtime/op.(*Catcher).Pull.func1()
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/op/catcher.go:25 +0x45
panic({0x19f1ac0, 0x1d64e40})
	/usr/local/opt/go/libexec/src/runtime/panic.go:884 +0x212
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc000257290?, {0x1d6f990?, 0xc0005049e0?}, {0xc0005d4ed0?, 0x0?, 0xc0005049c0?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:20 +0x168
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc0005049e0}, 0xc00131cfe0?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc0005049c0?}, {0xc0005d4ed0?, 0x0?, 0xc0005049a0?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc0005049c0}, 0xc00131d0c0?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc0005049a0?}, {0xc0005d4ed0?, 0x0?, 0xc000504980?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc0005049a0}, 0xc00131d1a0?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc000504980?}, {0xc0005d4ed0?, 0x0?, 0xc000504960?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc000504980}, 0xc00131d280?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc000504960?}, {0xc0005d4ed0?, 0x0?, 0xc000504940?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc000504960}, 0xc00131d360?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc000504940?}, {0xc0005d4ed0?, 0x0?, 0xc000504920?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc000504940}, 0xc00131d440?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc000504920?}, {0xc0005d4ed0?, 0x0?, 0xc000504900?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc000504920}, 0xc00131d520?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc000504900?}, {0xc0005d4ed0?, 0x0?, 0xc0005048e0?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc000504900}, 0xc00131d600?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc0005048e0?}, {0xc0005d4ed0?, 0x0?, 0xc0005048c0?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc0005048e0}, 0xc00131d6e0?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc0005048c0?}, {0xc0005d4ed0?, 0x0?, 0xc0005048a0?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc0005048c0}, 0xc00131d7c0?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc0005048a0?}, {0xc0005d4ed0?, 0x0?, 0xc000504880?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc0005048a0}, 0xc00131d8a0?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc000504880?}, {0xc0005d4ed0?, 0x0?, 0xc000504860?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc000504880}, 0xc00131d980?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc000504860?}, {0xc0005d4ed0?, 0x0?, 0xc000504840?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc000504860}, 0xc00131da60?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc000504840?}, {0xc0005d4ed0?, 0x0?, 0xc000504820?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc000504840}, 0xc00131db40?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc000504820?}, {0xc0005d4ed0?, 0x0?, 0xc000504800?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc000504820}, 0xc00131dc20?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc000504800?}, {0xc0005d4ed0?, 0x0?, 0xc0005047e0?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc000504800}, 0xc00131dd00?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc0005047e0?}, {0xc0005d4ed0?, 0x0?, 0xc0005047c0?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc0005047e0}, 0xc00131dde0?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc0005047c0?}, {0xc0005d4ed0?, 0x0?, 0xc0005047a0?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc0005047c0}, 0xc00131dec0?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc0005047a0?}, {0xc0005d4ed0?, 0x0?, 0xc000504780?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc0005047a0}, 0xc00131dfa0?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc000504780?}, {0xc0005d4ed0?, 0x0?, 0xc000504760?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc000504780}, 0xc00131e080?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc000504760?}, {0xc0005d4ed0?, 0x0?, 0xc000504740?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc000504760}, 0xc00131e160?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc000504740?}, {0xc0005d4ed0?, 0x0?, 0xc000504720?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc000504740}, 0xc00131e240?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc000504720?}, {0xc0005d4ed0?, 0x0?, 0xc000504700?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc000504720}, 0xc00131e320?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc000504700?}, {0xc0005d4ed0?, 0x0?, 0xc0005046e0?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc000504700}, 0xc00131e400?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc0005046e0?}, {0xc0005d4ed0?, 0x0?, 0xc0005046c0?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc0005046e0}, 0xc00131e4e0?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc0005046c0?}, {0xc0005d4ed0?, 0x0?, 0xc0005046a0?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc0005046c0}, 0xc00131e5c0?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc0005046a0?}, {0xc0005d4ed0?, 0x0?, 0xc000504680?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc0005046a0}, 0xc00131e6a0?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc000504680?}, {0xc0005d4ed0?, 0x0?, 0xc000504660?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc000504680}, 0xc00131e780?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc000504660?}, {0xc0005d4ed0?, 0x0?, 0xc000504640?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc000504660}, 0xc00131e860?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc000504640?}, {0xc0005d4ed0?, 0x0?, 0xc000504620?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc000504640}, 0xc00131e940?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc000504620?}, {0xc0005d4ed0?, 0x0?, 0xc000504600?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc000504620}, 0xc00131ea20?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc000504600?}, {0xc0005d4ed0?, 0x0?, 0xc0005045e0?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc000504600}, 0xc00131eb00?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc0005045e0?}, {0xc0005d4ed0?, 0x0?, 0xc0005045c0?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc0005045e0}, 0xc00131ebe0?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc0005045c0?}, {0xc0005d4ed0?, 0x0?, 0xc0005045a0?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc0005045c0}, 0xc00131ecc0?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc0005045a0?}, {0xc0005d4ed0?, 0x0?, 0xc000504580?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc0005045a0}, 0xc00131eda0?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc000504580?}, {0xc0005d4ed0?, 0x0?, 0xc000504560?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc000504580}, 0xc00131ee80?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc000504560?}, {0xc0005d4ed0?, 0x0?, 0xc000504540?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc000504560}, 0xc00131ef60?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc000504540?}, {0xc0005d4ed0?, 0x0?, 0xc000504520?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc000504540}, 0xc00131f040?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc000504520?}, {0xc0005d4ed0?, 0x0?, 0xc000504500?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc000504520}, 0xc00131f120?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc000504500?}, {0xc0005d4ed0?, 0x0?, 0xc0005044e0?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc000504500}, 0xc00131f200?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc0005044e0?}, {0xc0005d4ed0?, 0x0?, 0xc0005044c0?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc0005044e0}, 0xc00131f2e0?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc0005044c0?}, {0xc0005d4ed0?, 0x0?, 0xc0005044a0?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc0005044c0}, 0xc00131f3c0?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc0005044a0?}, {0xc0005d4ed0?, 0x0?, 0xc000504480?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc0005044a0}, 0xc00131f4a0?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc000504480?}, {0xc0005d4ed0?, 0x0?, 0xc000504460?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc000504480}, 0xc00131f580?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc000504460?}, {0xc0005d4ed0?, 0x0?, 0xc000504440?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc000504460}, 0xc00131f660?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc000504440?}, {0xc0005d4ed0?, 0x0?, 0xc000504420?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc000504440}, 0xc00131f740?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc000504420?}, {0xc0005d4ed0?, 0x0?, 0xc000504400?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
github.com/brimdata/zed/runtime/expr.(*Call).Eval(0xc0003c9040, {0x1d71bb0?, 0xc000504420}, 0xc00131f820?)
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/eval.go:828 +0x84
github.com/brimdata/zed/runtime/expr.(*UDF).Call(0xc00031f5d0, {0x1d6f990?, 0xc000504400?}, {0xc0005d4ed0?, 0x0?, 0xc0005043e0?})
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/runtime/expr/udf.go:26 +0x132
created by github.com/brimdata/zed/service.handleQuery
	/private/var/folders/fl/2wdg4knx65jb4xw3bjygdjsw0000gn/T/xfs-22890817/service/handlers.go:71 +0x4d2

Comparing the two, I can see a few ways it could be improved:

  1. It would be more readable if there were line breaks like we saw at the CLI.
  2. It might also be more readable in fixed with font.
  3. Most importantly, there's no vertical scrollbar, so the user can't easily see the whole output, such as if they wanted to cut & paste it to send to us for help. Feeling hackish, I realized I could zoom out to make the font super small and then highlight it all, but I suspect many users would not make this connection and instead just cut & paste the parts that were visible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant