-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creation of chromium binaries in /tmp/ #2914
Comments
@malinka-2233: Thanks for reporting. We were not previously aware it was doing this. For the benefit of our developers, I've attached a video that reproduces the issue with GA Zui v1.4.1 on Ubuntu 20.04. I start out with the Repro.mp4I did some web searching and it looks like another project at element-hq/element-web#17188 struggled with the exact same symptom. In their case it looks like they were able to solve it using the change in https://github.com/vector-im/element-desktop/pull/337/files. What I don't know is if Zui uses "native modules" in a similar way and if it would benefit from the same fix. However, one of our developers will likely chime in with more insight on that. |
Thank you for clarifying, i assumed it was known so was not going into the details. |
Apparently it does. $ npm exec asar list /Applications/Zui.app/Contents/Resources/app.asar | grep '\.node$'
/node_modules/keytar/build/Release/keytar.node
/node_modules/node-pipe/build/Release/pipe.node |
Verified in Zui Insiders 1.4.2-8, which is based on Zui commit 288bb82. In the video below, the original repro steps are repeated with that release and we no longer see the Verify.mp4The next GA Zui release will have this fix as well. I hope to have that release out some time next week. |
Hey. While using the latest zui deb package v1.4.1 i noticed, that there are chromium binary files being created and executed at runtime. My question is - what part of the build\packaging of zui causes them to appear and is there anything to be done to avoid that?
Maybe i can manually unpack asar and run the electron part without using the resulting zui binary or is there any other way?
The text was updated successfully, but these errors were encountered: