Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't open pcap slice if the conn contains "files" activity #2980

Closed
philrz opened this issue Jan 20, 2024 · 1 comment · Fixed by #2981
Closed

Can't open pcap slice if the conn contains "files" activity #2980

philrz opened this issue Jan 20, 2024 · 1 comment · Fixed by #2981
Assignees
Labels
bug Something isn't working

Comments

@philrz
Copy link
Contributor

philrz commented Jan 20, 2024

tl;dr

A change in Zeek broke Zui's Download Packets functionality if related conn record has an associated files record. I've already figured out a fix and will have a PR up shortly.

Details

Repro is with Zui commit e275ddd with the attached ifconfig.pcapng.gz test data (after gunziping).

As shown in the attached video, to repro:

  1. Load the pcap
  2. Click the conn record
  3. Click the Download Packets button and find nothing happens
Repro.mp4

The error message that shows up in the console as I click:

17:57:35.719 › Error: "proto" not present in ["_path", "ts", "fuid", "uid", "id", "source", "depth", "analyzers", "mime_type", "filename", "duration", "local_orig", "is_orig", "seen_bytes", "total_bytes", "missing_bytes", "overflow_bytes", "timedout", "parent_fuid", "md5", "sha1", "sha256", "extracted", "extracted_cutoff", "extracted_size"]
    at _Record._getField (/Users/phil/work/zui/apps/zui/dist/main.js:91039:13)
    at _Record.getField (/Users/phil/work/zui/apps/zui/dist/main.js:91005:19)
    at _Record.get (/Users/phil/work/zui/apps/zui/dist/main.js:91001:24)
    at getSearchArgsFromConn (/Users/phil/work/zui/apps/zui/dist/main.js:97870:17)
    at downloadPackets (/Users/phil/work/zui/apps/zui/dist/main.js:97884:18)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
@philrz
Copy link
Contributor Author

philrz commented Jan 23, 2024

Verified in Zui commit a5ee8af.

As shown in the attached video, now when the Download Packets button is clicked the pcap slice opens in Wireshark as expected.

Verify.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant