Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opaque error in stacked bar area when there's no data to plot #3081

Closed
philrz opened this issue Jun 3, 2024 · 1 comment · Fixed by #3085
Closed

Opaque error in stacked bar area when there's no data to plot #3081

philrz opened this issue Jun 3, 2024 · 1 comment · Fixed by #3085

Comments

@philrz
Copy link
Contributor

philrz commented Jun 3, 2024

Repro is with Zui commit bfbb55e.

When a user clicks the + and selects New Query Session it starts a new tab without a pool pin and hence there's no initial Zed query or results. As shown in the attached video, at this point the stacked bar chart area shows the error message No date range found with 'ts'.

Verify.mp4

As detailed in #3079, this message used to be undefined: pool not found, which was also not ideal.

Since this state came about through an innocent set of clicks in the app, it seems we should catch this case and surface something a bit clearer and phrased less like an error.

@philrz
Copy link
Contributor Author

philrz commented Jun 11, 2024

Verified in Zui commit 21abbf6.

As shown in the attached video, now when clicking the + and selecting New Query Session, the stacked bar chart is no longer shown. A different message appears below No Pool Specified based on whether or not there's existing pools.

Verify.mp4

Thanks @jameskerr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant