Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle line breaks & super wide lines in error messages #530

Closed
philrz opened this issue Apr 1, 2020 · 1 comment · Fixed by #728
Closed

Handle line breaks & super wide lines in error messages #530

philrz opened this issue Apr 1, 2020 · 1 comment · Fixed by #728
Assignees
Labels
bug Something isn't working

Comments

@philrz
Copy link
Contributor

philrz commented Apr 1, 2020

Found in Brim commit 3b912ea talking to zqd tagged v0.7.0.

While verifying an issue, I saw that some of this helpful error message ran off the side of the screen.

image.png

Based on how it looks, there almost certainly were line breaks in the original error message. It'd be ideal if we could include those so the user can more easily cut & paste the whole thing, such as for sharing with us in a support situation.

@mikesbrown also discovered a similar class of issue: Super long lines that may not even have line breaks in them. Perhaps we'd want a horizontal scrollbar, or perhaps we'd want to wrap them. I know our CI automation takes screenshots during failures and would probably like to be able to see as much text as possible, so perhaps lean toward the latter?

image

@philrz philrz changed the title Include line breaks in error messages Handle line breaks & super wide lines in error messages Apr 20, 2020
@philrz philrz added the bug Something isn't working label Apr 20, 2020
@mason-fish mason-fish self-assigned this Apr 27, 2020
@jameskerr jameskerr self-assigned this May 1, 2020
@philrz philrz linked a pull request May 2, 2020 that will close this issue
@philrz
Copy link
Contributor Author

philrz commented May 2, 2020

Verified in Brim commit 670d3b8 talking to zqd commit a09d0d6.

I was able to trigger a nice long error message by commenting out this line in zdeps/zeek/zeek:

export ZEEK_PLUGIN_PATH=$dir/lib/zeek/plugins

When I try to import a pcap, the error message that comes up now wraps so I can see the whole thing:

image

(cc: @mikesbrown... I know you'd bumped into this one as well.)

Thanks @jameskerr!

@philrz philrz closed this as completed May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants