windows ci artifacts aren't collected upon failure

[philrz]

@mikesbrown explains:

---

https://github.com/brimsec/brim/runs/524561824

Run actions/upload-artifact@v11s
##[error]Exit code 1 returned from process: file name 'c:\runners\2.165.2\bin\Runner.PluginHost.exe', arguments 'action "GitHub.Runner.Plugins.Artifact.PublishArtifact, Runner.Plugins"'.
Run actions/upload-artifact@v1
  with:
    name: artifacts
    path: /var/tmp/brimsec/logs
Uploading artifact 'artifacts' from 'D:\var\tmp\brimsec\logs' for run #185
Uploading 5 files
File error 'The process cannot access the file 'D:\var\tmp\brimsec\logs\smoke.test.js1-chromedriver.log' because it is being used by another process.' when uploading file 'D:\var\tmp\brimsec\logs\smoke.test.js1-chromedriver.log'.
File error 'The process cannot access the file 'D:\var\tmp\brimsec\logs\smoke.test.js2-chromedriver.log' because it is being used by another process.' when uploading file 'D:\var\tmp\brimsec\logs\smoke.test.js2-chromedriver.log'.
Associated artifact artifacts (1115537) with run #185
##[error]The process cannot access the file 'D:\var\tmp\brimsec\logs\smoke.test.js2-chromedriver.log' because it is being used by another process.
##[error]Exit code 1 returned from process: file name 'c:\runners\2.165.2\bin\Runner.PluginHost.exe', arguments 'action "GitHub.Runner.Plugins.Artifact.PublishArtifact, Runner.Plugins"'.

This isn't a problem on windows in general.

A test branch where this is applied

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 320fd72c..86ab496f 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -67,7 +67,6 @@ jobs:
         # collection.
         WORKSPACE: /var/tmp/brimsec
     - uses: actions/upload-artifact@v1
-      if: failure()
       with:
         name: artifacts
         path: /var/tmp/brimsec/logs

is able to collect artifacts.

https://github.com/brimsec/brim/runs/528634251

[alfred-landrum]

@mikesbrown : did we fix this with the windows ci work last week?

[mikesbrown]

@alfred-landrum I hadn't had an opportunity to notice. I went back and found https://github.com/brimsec/brim/runs/596826483 which contains artifacts. Interestingly those failures are on master and nothing I've seen before. I'll follow up on them.

[mikesbrown]

I'll follow up on them.

brimdata/super#613