Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingest ZNG-format Zeek logs #693

Closed
philrz opened this issue Apr 27, 2020 · 4 comments · Fixed by #717
Closed

Ingest ZNG-format Zeek logs #693

philrz opened this issue Apr 27, 2020 · 4 comments · Fixed by #717
Assignees

Comments

@philrz
Copy link
Contributor

philrz commented Apr 27, 2020

In the original vision for opening Zeek logs as captured in #566, it was expected that ZNG would be among the accepted formats. At the moment (Brim commit f837314 talking to zqd tagged v0.12.0) attempting to load such logs into Brim gives the "Unknown file types" error, so it seems we still have work left to do here.

Like we did for Zeek TSV/JSON, we could provide a hyperlink from any ZNG reference, in this case to https://github.com/brimsec/zq/tree/master/zng/docs.

@henridf
Copy link
Contributor

henridf commented Apr 28, 2020

It sounds like this issue would require extending the Brim app's autodetection to recognize zng formatted logs? If so an alternate option might be to add a "output type" flag to zq (that just runs zq's detection mechanism and writes the detected format to stdout) and have Brim run zq with that flag that way to detect the format of input files. The zq work for this would be super easy, and this way Brim wouldn't have to re-implement another detection scheme. Just a 2c idea.

@alfred-landrum
Copy link
Contributor

@henridf : thank you, our plan from discussions today is to make this very simple: Brim will only try to identify pcaps. If it doesn't identify a file as a pcap, it will assume it's some type of log, and send it via the log ingest api (including the json typings), and let zqd figure out what format it is.

@jameskerr jameskerr assigned jameskerr and unassigned jameskerr Apr 29, 2020
@mason-fish mason-fish self-assigned this Apr 29, 2020
@jameskerr
Copy link
Member

@mason-fish The functionality of this has been fixed in this PR: #716 Let's just make this ticket about the UI (add zng to the list of supported formats with a link to the zng docs.)

@philrz
Copy link
Contributor Author

philrz commented May 1, 2020

Verified in Brim commit 7e0f417 talking to zqd commit 43d474d. In the video below, I drag the ZNG and TZNG logs from the zq-sample-data into separate tabs of the Brim app and they both import fine.

Verify.mp4.zip

Thanks @mason-fish!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants