Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: +1/+1 bonus counter #86

Open
Capitoste opened this issue Mar 6, 2014 · 4 comments
Open

Feature request: +1/+1 bonus counter #86

Capitoste opened this issue Mar 6, 2014 · 4 comments

Comments

@Capitoste
Copy link

It would be good to have a new +1+1 bonus counter, different from that blue +1+1 counter already available. So often we have to differenciate between actual +1+1 counters (the ones that remain in permanents) from +1+1 bonuses (the ones that are given from cards like honor of the pure or elvish archdruid).

@DotChris
Copy link

While I'm sure adding a new marker type wouldn't be too difficult of a request,(at a glance looks like)

def addPlusOneBonus(card, x = 0, y = 0):

    mute()
    notify("{} adds a +1/+1 bonus to {}.".format(me, card))
   [logic here]

(obviously there is some other stuff like graphics and adding it in other places too)

I wondered if there was a way to script it instead. I tried using the scryfall api to target cards that add +x/+x using the regex re:"( get | gets )(+\d/+\d)" or https://api.scryfall.com/cards/search?q=re%3A%22(+get+|+gets+)(%2B\d%2F%2B\d)%22 to grab the list of cards. One could then cache this data and then narrow down the list further by setting cases for "other" "this" "target" etc. I haven't looked too much into if power/toughness are static or loaded onto cards dynamically, but this would be a cool option and less time keeping track of bonuses.

@brine
Copy link
Owner

brine commented Sep 24, 2017

I've been avoiding power/toughness modifiers mainly as I haven't figured out a proper way to display them, I really don't like the idea of using counters as it gets way too messy when there's different counters on a card (especially +1/+1 counters). We don't really have a way to put text overlays over the cards, which would be IMO the cleanest way to handle it.

@DotChris
Copy link

I agree, maybe for now, it would be a step to at least calculate bonuses and counters. Then, maybe a button that says calculate power/toughness and outputs it to chat for everyone. This would definitely be some major updating.

On the visual note:
Would have to use a blank P/T area like in the newer cards probably white because it'll be easier to modify to other colors.
Select Color(maybe prefab each version)
Calculate P/T
Then place on (X,Y) of the card.

I have no idea on how to implement the images with OCTGN, maybe some derivative of markers. Pretty new to OCTGN's stuff, seeing that the scripts are in python is it possible to implement pillow to add images and text?

@brine
Copy link
Owner

brine commented Sep 26, 2017

well one thing I've been pushing for is the ability to have proxy images render whenever a card property changes (as python allows you to change the default values of a card property), which would in theory allow cards to display modified values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants