You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Function ExternalConnection::sendStatus consumes deviceState argument.
This argument does not make any sense because not in all cases it is used or it is overwritten!
Refactor the function in a manner that does not need deviceState argument (it is always used with value ExternalProtocol::Status_DeviceState_DISCONNECT, connect, ...).
Split function in two - for standard status and for disconnect status...? Or use explicit enum class and not reuse protobuf message state?
The text was updated successfully, but these errors were encountered:
Function ExternalConnection::sendStatus consumes deviceState argument.
This argument does not make any sense because not in all cases it is used or it is overwritten!
Refactor the function in a manner that does not need deviceState argument (it is always used with value ExternalProtocol::Status_DeviceState_DISCONNECT, connect, ...).
Split function in two - for standard status and for disconnect status...? Or use explicit enum class and not reuse protobuf message state?
The text was updated successfully, but these errors were encountered: