Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ExternalConnection::sendStatus #30

Open
koudis opened this issue Aug 9, 2024 · 0 comments
Open

Refactor ExternalConnection::sendStatus #30

koudis opened this issue Aug 9, 2024 · 0 comments

Comments

@koudis
Copy link
Member

koudis commented Aug 9, 2024

Function ExternalConnection::sendStatus consumes deviceState argument.

This argument does not make any sense because not in all cases it is used or it is overwritten!

Refactor the function in a manner that does not need deviceState argument (it is always used with value ExternalProtocol::Status_DeviceState_DISCONNECT, connect, ...).

Split function in two - for standard status and for disconnect status...? Or use explicit enum class and not reuse protobuf message state?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant