Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Goodreads link for items starting with A to E in the data.js file #270

Open
brittanyrw opened this issue Oct 8, 2019 · 2 comments · May be fixed by #289
Open

Add Goodreads link for items starting with A to E in the data.js file #270

brittanyrw opened this issue Oct 8, 2019 · 2 comments · May be fixed by #289
Assignees
Labels
javascript Issue requires modification of JavaScript Pending PR

Comments

@brittanyrw
Copy link
Owner

brittanyrw commented Oct 8, 2019

If you would like to work on this Issue, comment below and wait for confirmation before starting to code.

Add the itemLink url for book objects that start with A to E in the data.js file.

The object currently looks like this:

  {
    title: "Alexander Hamilton",
    author: "Ron Chernow",
    emojiImgs: "🇺🇸⚔️💵👨",
    genres: ["non-fiction", "biography"],
    year: 2004
  }

It should now look like this:

  {
    title: "Alexander Hamilton",
    author: "Ron Chernow",
    emojiImgs: "🇺🇸⚔️💵👨",
    genres: ["non-fiction", "biography"],
    year: 2004,
    itemLink: "https://www.goodreads.com/book/show/16130.Alexander_Hamilton"
  }

The itemLink should be a link to the book on Goodreads.

Also for your section of objects (starting with A to E) if they are not already in the correct alphabetical order, please reorder them so that they are in alphabetical order.

@ghost ghost added the needs review label Oct 8, 2019
@brittanyrw brittanyrw changed the title Add Goodreads link for items starting with A & B in the data.js file Add Goodreads link for items starting with A to C in the data.js file Oct 8, 2019
@brittanyrw brittanyrw changed the title Add Goodreads link for items starting with A to C in the data.js file Add Goodreads link for items starting with A to D in the data.js file Oct 8, 2019
@brittanyrw brittanyrw changed the title Add Goodreads link for items starting with A to D in the data.js file Add Goodreads link for items starting with A to E in the data.js file Oct 8, 2019
@brittanyrw brittanyrw added enhancement New feature or request javascript Issue requires modification of JavaScript help wanted Extra attention is needed and removed needs review labels Oct 8, 2019
@maxleee
Copy link

maxleee commented Oct 11, 2019

Hi! Can I take this one?

@brittanyrw
Copy link
Owner Author

Hi @maxleee, sure I will assign this to you!

@maxleee maxleee linked a pull request Oct 11, 2019 that will close this issue
@ghost ghost added the Pending PR label Oct 11, 2019
@brittanyrw brittanyrw removed help wanted Extra attention is needed enhancement New feature or request labels Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Issue requires modification of JavaScript Pending PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants