Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle for dark and light theme #278

Open
5 tasks
brittanyrw opened this issue Oct 8, 2019 · 2 comments
Open
5 tasks

Add toggle for dark and light theme #278

brittanyrw opened this issue Oct 8, 2019 · 2 comments
Assignees
Labels
CSS Issue requires modification of CSS javascript Issue requires modification of JavaScript

Comments

@brittanyrw
Copy link
Owner

brittanyrw commented Oct 8, 2019

If you would like to work on this Issue, comment below and wait for confirmation before starting to code.

Add a toggle button somewhere on the homepage (maybe the top right corner) that will let a user switch between a light theme and a dark theme.

The current theme serves as a dark theme so you need to update the CSS to add a light theme. Use the colors that are already in the website (lighter versions of those colors) or colors that are similar. Let me know if you need me to provide color palettes for you.

For all themes, the background color of the container the emoji images are in must be white.

Suggested to do list:

  • Determine placement of toggle button.
  • Add HTML to index.html for the toggle button.
  • Update app.js for the functionality of the toggle button.
  • Add CSS for a light theme in main.css.
  • Make sure the position of the toggle button works on all screen sizes.
@ghost ghost added the needs review label Oct 8, 2019
@brittanyrw brittanyrw added CSS Issue requires modification of CSS enhancement New feature or request javascript Issue requires modification of JavaScript help wanted Extra attention is needed hacktoberfest and removed needs review labels Oct 8, 2019
@jyoungiv
Copy link

jyoungiv commented Oct 9, 2019

I can work on this!

@brittanyrw
Copy link
Owner Author

@jyoungiv Great! I have assigned this to you. Feel free to comment here if you have any questions or need more information.

@brittanyrw brittanyrw removed help wanted Extra attention is needed enhancement New feature or request labels Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Issue requires modification of CSS javascript Issue requires modification of JavaScript
Projects
None yet
Development

No branches or pull requests

2 participants