Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Java cross version testing #92

Open
britter opened this issue Jan 20, 2023 · 1 comment
Open

Add Java cross version testing #92

britter opened this issue Jan 20, 2023 · 1 comment
Milestone

Comments

@britter
Copy link
Owner

britter commented Jan 20, 2023

To prevent problems like the one fixed in #89 in the future.

@britter britter added this to the 0.4.2 milestone Jan 20, 2023
@dariuszkuc
Copy link
Contributor

TLDR the underlying issue is that org.apache.maven.plugin-tools:maven-plugin-tools relies on ASM which needs to be updated to support target JVM bytecode, e.g. maven-plugin-tools v3.6.1 uses asm v9.1 which supports Java 17.

When doing the update in #89 I tried updating to the latest maven-plugin-tools version (currently v.3.7.1 which supports up to Java 20) but all versions >3.6.1 where throwing failures with missing noaop jar

Execution failed for task ':plugin:compileKotlin'.
> Error while evaluating property 'filteredArgumentsMap' of task ':plugin:compileKotlin'
   > Could not resolve all files for configuration ':plugin:compileClasspath'.
      > Could not find sisu-guice-3.2.3-noaop.jar (org.sonatype.sisu:sisu-guice:3.2.3).
        Searched in the following locations:
            https://repo.maven.apache.org/maven2/org/sonatype/sisu/sisu-guice/3.2.3/sisu-guice-3.2.3-noaop.jar

@britter britter modified the milestones: 0.4.2, 0.4.3 Jun 5, 2023
@britter britter modified the milestones: 0.4.3, 1.x Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants