Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UWP #10

Closed
wants to merge 2 commits into from
Closed

Add UWP #10

wants to merge 2 commits into from

Conversation

Depechie
Copy link

@Depechie Depechie commented Oct 4, 2019

BEWARE: DON'T AUTO MERGE
Maybe merge into a separate branch

Fixes #6
This is a try out to see if we can add UWP.
But because I'm not familiar with the OAuth flow of the GitHub API, I have no idea how to get it running on UWP.
Meaning, the app builds, starts up and will show you the Settings page to connect to GitHub but will not do the redirect.

Also UWP does not yet support NetStandard 2.1, thus the GitTrends project has been fully downgraded to 2.0.

#3
Added UWP but by no means did a full test run... I think best idea would be if Brandon could go through it quickly :)
Also UWP does not support 2.1 net standard, so GitTrends project is also downgraded to accomodate
@brminnick
Copy link
Owner

brminnick commented Oct 4, 2019

Thanks Glenn!

To accomplish the redirect, you'll just need to configure the UWP URL scheme

  • Display Name: GitTrends
  • Name: gittrends

Here's an example of how to configure UWP URL Schemes from a workshop that Jim, Laurent and I put together: https://github.com/jimbobbennett/MobileAppsOfTomorrow-Lab/blob/master/Workshop/3_3-CreateAnAzureServiceInTheMobileAppWin.md#2-configuring-the-url-scheme

@brminnick
Copy link
Owner

And it looks like UWP .NET Standard 2.1 Support is coming down the pike! https://stackoverflow.com/a/58086783/5953643

@brminnick brminnick changed the title Issue 6 Add UWP Oct 7, 2019
@brminnick
Copy link
Owner

Update: I'm following this thread for .NET Standard 2.1 Support on UWP: dotnet/standard#1567

@brminnick
Copy link
Owner

Closing this PR as it is too many commits behind the main branch and has too many merge conflicts to be recoverable once .NET Standard 2.1 supports UWP.

Will open a new PR once UWP adds .NET Standard 2.1 support 👍

@brminnick brminnick closed this Jul 23, 2020
@mediaexplorer74
Copy link

mediaexplorer74 commented May 27, 2023

BEWARE: DON'T AUTO MERGE Maybe merge into a separate branch

Fixes #6 This is a try out to see if we can add UWP. But because I'm not familiar with the OAuth flow of the GitHub API, I have no idea how to get it running on UWP. Meaning, the app builds, starts up and will show you the Settings page to connect to GitHub but will not do the redirect.

Also UWP does not yet support NetStandard 2.1, thus the GitTrends project has been fully downgraded to 2.0.

Hi, Glenn. Please made switch your GitTrends's fork from private state to public... =) UWP theme is cool. I want to download your "two patches" (UWP head + netstandard 2.0 downgrade) and then to try to downgrade to net standard 1.4...
Best,
ME

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Desktop Support
3 participants