Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis scripts should gracefully exit for external users #1717

Closed
kshakir opened this issue Nov 30, 2016 · 0 comments
Closed

Travis scripts should gracefully exit for external users #1717

kshakir opened this issue Nov 30, 2016 · 0 comments

Comments

@kshakir
Copy link
Contributor

kshakir commented Nov 30, 2016

Currently when an external user attempts to access our cloud accounts, Travis does not hand out the encryption keys. This is desired behavior, as we do not want to run up bills on unknown code from outside users.

However, currently our test scripts are not checking the variable TRAVIS_SECURE_ENV_VARS, and are instead trying to access encrypted variables that are not and never will be present. This leads to false negatives where the tests are marked as failed, when instead they should best case be marked as ignored, worst case be marked as implicitly passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant