Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAMSequenceDictionary for 2bit references is not in a good order #2037

Closed
cwhelan opened this issue Jul 22, 2016 · 4 comments
Closed

SAMSequenceDictionary for 2bit references is not in a good order #2037

cwhelan opened this issue Jul 22, 2016 · 4 comments
Assignees
Milestone

Comments

@cwhelan
Copy link
Member

cwhelan commented Jul 22, 2016

When using a 2bit reference, the sequence dictionary appears to be in an arbitrary order. When used to sort VCF files, this produces very strangely sorted variants. It would be nice if there was some way to associate reference index files (ie .fasta.fai) with a 2bit reference, or some other solution for getting a useable sequence dictionary when using 2bit references.

@droazen droazen added this to the alpha-3 milestone Jul 29, 2016
@droazen droazen modified the milestones: beta, alpha-3, 4.0 release Mar 20, 2017
@droazen
Copy link
Contributor

droazen commented Oct 17, 2017

This is fixed in bigdatagenomics/adam#1508, but that project needs to do a release in order for us to get the fix.

@droazen
Copy link
Contributor

droazen commented Oct 17, 2017

According to the ADAM people, a release is imminent within the next few weeks, so we can upgrade once it's out to fix this.

@droazen
Copy link
Contributor

droazen commented Jan 16, 2018

I believe this was fixed by #4044 -- @cwhelan or @tedsharpe can you please confirm?

@droazen droazen modified the milestones: Engine-4.0, Engine-4.1 Jan 16, 2018
@tedsharpe
Copy link
Contributor

@droazen @cwhelan Yes, it appears to be fixed. (Don't have a failing test that I can run on the old behavior, but a quick test of the latest code in master appears to have repaired the flaw.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants