Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FilterVariantTranches should be written entirely in Java #4535

Closed
cmnbroad opened this issue Mar 19, 2018 · 5 comments
Closed

FilterVariantTranches should be written entirely in Java #4535

cmnbroad opened this issue Mar 19, 2018 · 5 comments
Assignees
@lucidtronix @cmnbroad
Labels
CNN
Milestone
Engine-2Q2018

Comments

@cmnbroad
Copy link
Collaborator

FilterVariantTranches currently has a thin Java layer that is a pass-through to Python, but can be written entirely in Java.
@cmnbroad cmnbroad added the CNN label Mar 19, 2018
This was referenced May 7, 2018
Open
Open
@lbergelson
Copy link
Member

Seems like something like #4794 could be avoided if we rewrote this. It seems like a pretty simple rewrite too...

@droazen
Copy link
Contributor

droazen commented May 23, 2018

@lucidtronix Is this on your radar for this quarter? Engine team is happy to help with the conversion (we think it should be pretty easy) -- feel free to book some time on our calendar if you like.

@droazen droazen added this to the Engine-2Q2018 milestone May 23, 2018
@lucidtronix
Copy link
Contributor

The PR is in: #4800

@droazen
Copy link
Contributor

droazen commented May 23, 2018

@lucidtronix Sorry, saw that PR just after I posted the comment above :) Thanks for doing it!

@lbergelson
Copy link
Member

closed by #4800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucidtronix lucidtronix

@cmnbroad cmnbroad

Labels
CNN
Projects
None yet
Milestone
Engine-2Q2018
Development

No branches or pull requests
4 participants
@droazen @lucidtronix @lbergelson @cmnbroad