Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit GenomeLocParser overloads for validation arguments. #7300

Open
jamesemery opened this issue Jun 9, 2021 · 1 comment
Open

Audit GenomeLocParser overloads for validation arguments. #7300

jamesemery opened this issue Jun 9, 2021 · 1 comment

Comments

@jamesemery
Copy link
Collaborator

In the work on #7295 it became clear that there are a lot of overlapping overloads of the createGenomeLoc() method that has already caused some confusion since some overloads will skip the reference validation step. Somebody should audit all of the uses of GenomeLocParser and evaluate where validation is and isn't appropriate (possibly if you want an unvalidated genomeLoc use a SimpleInterval?) and wire them accordingly.

@jamesemery
Copy link
Collaborator Author

As it turns out some of the createGenomeLoc() instances are being used by the GermlineCNVPipeline tests (evidently in ValidateVariants) and will fail if genome validation is enabled. This should be investigated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant