Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExcessHet should perhaps implement ReducibleAnnotation. #7564

Open
samuelklee opened this issue Nov 15, 2021 · 2 comments
Open

ExcessHet should perhaps implement ReducibleAnnotation. #7564

samuelklee opened this issue Nov 15, 2021 · 2 comments
Assignees

Comments

@samuelklee
Copy link
Contributor

Seems like there are some commented overrides and method stubs, but there are also some remaining unimplemented methods. See #7394 (comment).

@droazen
Copy link
Contributor

droazen commented Nov 15, 2021

@ldgauthier Thoughts on this?

@samuelklee
Copy link
Contributor Author

@droazen just for context, I punted on this in the linked PR (I'm not too familiar with the annotation interfaces, and it wasn't immediately obvious to me how to implement the required methods for ExcessHet). So @ldgauthier asked me to file this on the off chance that someone else wants to look at it in the future, but I think it's probably low priority. Seems like someone might have taken a previous unsuccessful stab at it; there were a few vestigial, commented-out //@Override lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants