Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for cfgsave/cfgenable overwritten by later commit. #138

Open
xsYf6tdq8 opened this issue Aug 1, 2023 · 1 comment
Open

Fix for cfgsave/cfgenable overwritten by later commit. #138

xsYf6tdq8 opened this issue Aug 1, 2023 · 1 comment

Comments

@xsYf6tdq8
Copy link

Hi

The fix for the cfgsave issue mentioned in #100 (comment) has been made in commit 447a063 but has been overwritten (or rolled back) via commit 9d0d60d#r123304744.
The cfgsave was only implemented when deleting zones and not when adding.

For us this is quite a big issue as we don't want cfgenable with each new zone.

Wrong code:

                    if cfgname is not None:
                        failed_msg = "CFG ENABLE failed"
                        ret_code = cfg_enable(fos_ip_addr, https, auth, vfid,
                                            result, checksum, cfgname, timeout)
                    else:
                        failed_msg = "CFG SAVE failed"
                        ret_code = cfg_save(fos_ip_addr, https, auth, vfid,

Should be replaced with:

                 failed_msg = "CFG SAVE failed"
                    ret_code = cfg_save(fos_ip_addr, https, auth, vfid,
@prasad-valmeti-broadcom
Copy link
Collaborator

Thanks for letting us know. We will look into it and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants