Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl + C takes a very long time #3

Open
Globegitter opened this issue Jun 23, 2014 · 7 comments
Open

Ctrl + C takes a very long time #3

Globegitter opened this issue Jun 23, 2014 · 7 comments

Comments

@Globegitter
Copy link

After running broccoli serve and hitting Ctrl + C to stop the command it takes ~30 seconds until the command actually finished and the shell is responsive again.

All I did was cloning the sample app and running broccoli serve on that as-is.

@rwjblue
Copy link
Member

rwjblue commented Jun 23, 2014

This is because most of the operations are synchronous I believe.

@rwjblue
Copy link
Member

rwjblue commented Jun 23, 2014

Which means that the process exit handlers have to wait until the main thread is unlocked to run the cleanup task.

@Globegitter
Copy link
Author

Ah ok, so this means that at least for the time being there is no simple workaround?

@rwjblue
Copy link
Member

rwjblue commented Jun 23, 2014

Correct, but I do think a fix is possible, just not a quick-fix.

@joliss
Copy link
Member

joliss commented Mar 22, 2015

When I hit Ctrl+C during a build (either build or serve) with current Broccoli on iojs 1.5 on Linux, it exits immediately. However it doesn't clean up tmp directories. I'd like to revisit the tmp cleanup logic when the upcoming API change is done, as it centralizes the tmp dir handling.

Getting back to the issue at hand, do you still see the "delayed exit" behavior on Mac? I actually don't remember ever seeing this problem myself, so perhaps it's platform-specific.

@stefanpenner
Copy link

stefanpenner commented Dec 22, 2017

mid-build cancellation PR broccolijs/broccoli#350 (forward port from ember-cli's fork) should address this.

@kylecordes
Copy link

This continues to be a surprising behavior, and something to talk around when introducing Broccoli to a new developer. Other build tool CLIs exit promptly on control-C... it would be ideal to catch up with the mainstream on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants