Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing auto-complete in exercise name #147

Closed
ironjan opened this issue Jul 5, 2020 · 3 comments · Fixed by #156
Closed

Missing auto-complete in exercise name #147

ironjan opened this issue Jul 5, 2020 · 3 comments · Fixed by #156
Assignees

Comments

@ironjan
Copy link
Contributor

ironjan commented Jul 5, 2020

Describe the feature you'd like
Hello,
when using the app for the first time, I noticed some peculiarities in the exercise editor. This is applicable to both "free workout" and the program exercise editor.

Describe alternatives you've considered
I assume that 1. and 2. are per design. However, I'd suggest changing the current behavior as it may be confusing; especially the combination of both is quite annoying at the moment: there is no way to use auto-correct and - if a typo is noticed too late - the name has to be typed in completely anew.

Additional context
Feel free to assign this issue to me. However, it may take a while until I can actually work on it ;)

Also, I'm not sure if this issue should be split into three separate ones.

@brodeurlv
Copy link
Owner

Hi @ironjan, thank you for taking the time to open this issue. Usually, 3 issues should be opened for the simple reason that they might not be address at the same time. However looking at your issues, I believe everything can be addressed at once.
At least 2 and 3 seems straight forward.
For 1, the best approach would be to have a clearable EditView with a cross at the end of the view to clear if wanted.

If you want to take care of this, I'm completely ok with it. This seems a very good first contribution and there is no urgency for this topic. Do you have anyway an idea of when you could have the time to work on this ?
Thanks.

@ironjan
Copy link
Contributor Author

ironjan commented Jul 5, 2020

Most likely next weekend or the one after that.

I changed the issue to a task list to track the different parts. 2 & 3 will be straight-forward as you mentioned; 1 will be slightly more effort but should be similarly simple. Most likely each of the changes will be less or equal to 15 lines of code.

@ironjan
Copy link
Contributor Author

ironjan commented Jul 14, 2020

@brodeurlv as you might guess from the recent edits and new issues, some parts are more complicated as initially guessed and have been split out. 2/3 are submitted as PRs, #154 is still on my TODO list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants