Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV Export renaming of columns #49

Closed
brodeurlv opened this issue Oct 9, 2018 · 3 comments
Closed

CSV Export renaming of columns #49

brodeurlv opened this issue Oct 9, 2018 · 3 comments
Assignees

Comments

@brodeurlv
Copy link
Owner

Split of #32 but addressing only CSV.

Same for the profile export:
table, id, poids, date
poids -> weight

Why is the order different from the bodybuilding table export? Should be the same: table, id, date, weight

The Cardio export reads:
table, id, date, exercice, duration, distance, profil_id
So there is a spelling mistake:
exercice -> exercise

@alextsakpinis
Copy link
Contributor

Since I am already familiar with the topic of exports I would continue with that issue. Is that ok for you?

@brodeurlv
Copy link
Owner Author

brodeurlv commented May 3, 2021

Hi Alex, this one is more complicated than it seems. Changing the column name will break the compatibility of old exports.
Also, I would like to change all the mechanism of export to have something more robust and also something that can export the images as well in order to be able to share exercises library with others but maybe that's a completely different feature (#79). I'm not yet clear on this.
And then, I'm working on the migration to scoped storage so I am changing some stuff regarding the file access so it would be preferable to wait for this before changing anything to this, else, I'm not sure the merge will be easy.
I will let you know when I'm done. Thanks.

@alextsakpinis
Copy link
Contributor

I thought about loosing the combability with older versions when changing the column names and wanted to discuss that with you. But your answer already explained everything really well. I will then look for another open issue.

@brodeurlv brodeurlv self-assigned this Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants