Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Known issues with out-of-tree Windows platform support #23

Closed
brodycj opened this issue Jul 8, 2019 · 3 comments · Fixed by #264
Closed

Known issues with out-of-tree Windows platform support #23

brodycj opened this issue Jul 8, 2019 · 3 comments · Fixed by #264

Comments

@brodycj
Copy link
Owner

brodycj commented Jul 8, 2019

The existing implementation will generate a Windows implementation if requested but it should not be considered functionally stable for the following reasons:

  • does not seem to have a working native call
  • no working example for Windows
  • view option would be ignored
  • react-native-windows seems to have an upcoming “vnext” version with C++ instead of .NET projects, which is not supported at all by this tool

P.S. A major problem with react-native-windows: it seems to be now stuck on RN 0.59 for .NET (“current”), now seems to be updated to 0.60 for C++ (“vnext”). (It is desired for this tool to drop the deprecated RN 0.59 support in the near future.)

@brodycj
Copy link
Owner Author

brodycj commented Nov 15, 2019

I will cover this topic in #43.

@brodycj brodycj closed this as completed Nov 15, 2019
@brodycj brodycj changed the title Stable Windows support Known issues with out-of-tree Windows platform support Nov 15, 2019
@brodycj
Copy link
Owner Author

brodycj commented Nov 15, 2019

I changed my mind, just updated the title. My apologies for the noise.

@brodycj brodycj reopened this Nov 15, 2019
brodycj added a commit that referenced this issue Mar 2, 2020
OVERVIEW:

Windows is no longer supported for reasons discussed in #23 & #43

Moving the existing Windows C# template into `unsupported-platforms`,
will continue to be validated by the test suite for now (at least).

Removing the `uuid` package dependency which is no longer needed
(unless it is used for a supported platform again, someday).

Further discussion would be welcome *in a new issue* on GitHub.
brodycj added a commit that referenced this issue Mar 2, 2020
* General change notes

OVERVIEW:

Windows is no longer supported for reasons discussed in #23 & #43

Moving the existing Windows C# template into `unsupported-platforms`,
will continue to be validated by the test suite for now (at least).

Moving "unsupported-platforms" tests very carefully to preserve
the test coverage while avoiding excess test snapshot churn
in the git history.

Removing the `uuid` package dependency which is no longer needed
(unless it is used for a supported platform again, someday).

Further discussion would be welcome *in a new issue* on GitHub.

* rename & move unsupported Windows C# tests, with updated descriptions

(and updated test snapshots)

* update Windows windows-csharp tests to test Windows (C#) template only

* update windows-csharp test snapshots

* remove Windows support from templates/index.js

* rename templates/windows.js -> unsupported-platforms/windows-csharp.js

* copy templates/.eslintrc.yml into unsupported-platforms

* remove use of uuid from lib/lib.js

* update CLI error logging test snapshot

* remove uuid dependency from package dependencies

* update status of Windows platform in README.md

* remove obsolete section from README.md

* include unsupported-platforms/**/*.js in stryker.conf.js

* remove conditional determination of peerDependencies & devDependencies

which is no longer needed now that Windows platform support is gone

as discovered through mutation testing using Stryker Mutator
@brodycj
Copy link
Owner Author

brodycj commented Mar 2, 2020

Windows module support which was only available in C# is now gone due to the difficulties discussed here and in #43. I would be happy to consider supporting Windows again if there is sufficient interest and help from the user community. A new GitHub issue would be appreciated in case of any interest in supporting Windows again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant