Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to update existing modules for newer tool versions #19

Open
1 of 4 tasks
brodycj opened this issue Apr 9, 2019 · 1 comment
Open
1 of 4 tasks

How to update existing modules for newer tool versions #19

brodycj opened this issue Apr 9, 2019 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@brodycj
Copy link
Owner

brodycj commented Apr 9, 2019

See comment below for recommended procedure (as a workaround)

As requested in (updated):

For recent updates it is recommended to copy the updated entries from the following general areas into android/build.gradle:

For major version updates it is generally recommended to regenerate and copy the needed artifacts for Android into the existing module.

Labeled as a bug; I hope to get this documented in the near future.

TODO items (updated):

  • document a workaround upgrade procedure
  • add upgrade documentation in a similar style to: https://docs.expo.io/versions/v34.0.0/workflow/upgrading-expo-sdk-walkthrough/
  • fix generated android/build.gradle to read and use the packageIdentifier value from package.json, in order to make this Android build artifact zero percent customized
  • consider ideas for smoother upgrade support such as:
    • make an actual module template in a similar style to the react-native project template
    • make a native module seed similar to the Nativescript plugin seed
@brodycj brodycj added the bug Something isn't working label Apr 9, 2019
@brodycj brodycj changed the title How to update existing modules for newer Android tool versions How to update existing modules for newer tool versions Sep 20, 2019
@brodycj
Copy link
Owner Author

brodycj commented Sep 20, 2019

recommended upgrade procedure

Here is the recommended upgrade procedure, as a workaround:

  • generate a new module with the desired options, no need to have the generated example
  • copy android/build.gradle from the new module into the existing module, then apply customizations if needed
  • update package.json:
    • copy the updates to peerDependencies and devDependencies and ensure non-blank description value
    • or just copy package.json from the new module to the existing module
  • optional updates:
    • copy update to android/README.md (use of sudo was recently removed from the directions)
    • update the *.podspec file

optional steps:

  • generate another new module with generated example
  • copy updates to the following files:
    • example/ios/Podfile
    • scripts/examples_postinstall.js

/cc @iamchathu @friederbluemle @dlowder-salesforce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant