Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings.blacklistPattern is not working #1581

Closed
LearnDifferent opened this issue Dec 29, 2021 · 7 comments
Closed

settings.blacklistPattern is not working #1581

LearnDifferent opened this issue Dec 29, 2021 · 7 comments

Comments

@LearnDifferent
Copy link

Error details

settings.blacklistPattern is not working in Surfingkeys 1.0.0.

I've read https://github.com/brookhong/Surfingkeys/wiki/Migrate-your-settings-from-0.9.74-to-1.0 and #63 but still can't find the solution.

SurfingKeys: 1.0.0

Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.110 Safari/537.36

Context

Here is my settings:

settings.blacklistPattern = /leetcode-cn\.com/i;
@clarkwang
Copy link

Hit the same issue after updating to 1.0.0.

@clarkwang
Copy link

Just did a grep search in the Git repo but found no reference to blacklistPattern at all.

@brookhong
Copy link
Owner

Please use blocklistPattern.

@clarkwang
Copy link

Please use blocklistPattern.

Just tried and this works fine.

@LearnDifferent
Copy link
Author

Please use blocklistPattern.

Thanks.

@nashbridges
Copy link

@HaleTom
Copy link

HaleTom commented Jan 8, 2024

A hint for shorter regexes:

settings.blocklistPattern = /((calendar|mail).google|trello|duolingo|youtube|udemy).com/i

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants