Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.17.x] Alt-s (Toggle SurfingKeys on current site) stopped working #2157

Closed
clarkwang opened this issue Sep 18, 2024 · 22 comments
Closed

[v1.17.x] Alt-s (Toggle SurfingKeys on current site) stopped working #2157

clarkwang opened this issue Sep 18, 2024 · 22 comments

Comments

@clarkwang
Copy link

Since settings.blocklistPattern is not working (#2154) I tried <Alt-s> but it does not work either.

@gou4shi1
Copy link

Same here.

@clarkwang
Copy link
Author

clarkwang commented Sep 18, 2024

Enabling Developer mode does not fix the issue for me. Actually it's already enabled in my Chrome before updating to v1.17.

Steps I tried:

  1. Developer mode is initially enabled
  2. Disable Developer mode, then restart Chrome
  3. Enable Developer mode, then restart Chrome
  4. Now try <Alt-s> but it does not work for me.

@i-zanis
Copy link

i-zanis commented Sep 19, 2024

Experiencing same as above with dev mode on Vivaldi and Chrome.

@anderamko
Copy link

anderamko commented Sep 23, 2024

Please turn on Developer mode from chrome://extensions/ then restart your browser, it should work, see more #2159

This works but I can't stay whole day in dev mode.

EDIT: what works is:

  1. Enable dev mode.
  2. Restart chrome.

@clarkwang
Copy link
Author

Please turn on Developer mode from chrome://extensions/ then restart your browser, it should work, see more #2159

This works but I can't stay whole day in dev mode.

Enabling Developer mode does not fix the issue for me.

@lpanebr
Copy link

lpanebr commented Sep 27, 2024

Enabling Developer mode does not fix the issue for me.

@aspiers
Copy link
Contributor

aspiers commented Sep 29, 2024

I already had Developer mode permanently enabled. Restarting Chrome on a newer version after an upgrade of Chrome triggered this problem. I'm guessing the restart caused SurfingKeys to be upgraded to the new MV3 version which has this bug. I hope this can be fixed soon because SurfingKeys is totally unusable for me without Alt-s functioning, as I rely heavily on native shortcuts on some sites (e.g. gmail, github).

@brookhong
Copy link
Owner

This should have been fixed in 1.17.1.

@aspiers
Copy link
Contributor

aspiers commented Sep 29, 2024

I'm already on 1.17.1 and it's still the same bug :-(

@brookhong
Copy link
Owner

Hum, yes, there is still something need to be fixed, so far Alt-s would just disable current site on next page load(you could see how it works after page reloading), which is not expected, would fix this on next release.

@frankzvitale
Copy link

Also here to report the same issue, Alt-s is no longer working for me unfortunately. This also completely breaks the extension for me since I use native Jira keyboard shortcuts

@aspiers
Copy link
Contributor

aspiers commented Sep 30, 2024

The temporary workaround is to use Alt-i to enable pass-through, but it's a pain having to do that every time you open a site which requires it.

@aspiers
Copy link
Contributor

aspiers commented Oct 9, 2024

It's actually a lot worse than I thought:

  • Alt-i is cancelled by Escape so if you need to work on a website which uses Escape as a shortcut (and this is common), then every time you need to use it, you have to press Escape Escape Alt-i
  • Clicking on the extension icon and disabling SurfingKeys altogether doesn't work: it's shown as disabled but is still active! This is tracked in SurfingKeys does not disable on Chrome #2171.

BTW this is the ninth time this issue has happened 😢 See #101, #167, #168, #169, #170, #182, #382, and #1244 for the others. I'm not sure why it keeps happening, but as before I strongly recommend coding some regression tests so that it can never happen again.

@aspiers
Copy link
Contributor

aspiers commented Oct 9, 2024

I've had to disable the extension altogether 😢 There was no other way to stop it making sites like Gmail and Figma unusable. I really hope this issue can be fixed soon.

@NoRePercussions
Copy link

You can still build the last public version from source. It's less desirable than having it in the web stores, but it's fully functional.

@aspiers
Copy link
Contributor

aspiers commented Oct 9, 2024

You can still build the last public version from source. It's less desirable than having it in the web stores, but it's fully functional.

Good idea, thanks - I've done that. Unfortunately the installation steps are not fully documented; this is fixed in #1919 but it hasn't been merged yet.

@commiyou
Copy link

Based on the f152a9a build. You can refer to https://developer.chrome.com/docs/extensions/get-started/tutorial/scripts-on-every-tab for installation.

sk.zip

@AnkushMalaker
Copy link

Is this build supposed to fix it? It doesn't on my install @commiyou
Infact, I can't even disable or enable this using the GUI which sounds like #2171

@commiyou
Copy link

After following the documentation and installing the zip attachment, I can disable the extension using the shortcut

@clarkwang clarkwang changed the title [v1.17] Alt-s (Toggle SurfingKeys on current site) stopped working [v1.17.x] Alt-s (Toggle SurfingKeys on current site) stopped working Oct 14, 2024
@brookhong
Copy link
Owner

Fixed in 1.17.3.

@nanikit
Copy link

nanikit commented Oct 20, 2024

Is this issue really fixed? I'm currently using version 1.17.3 with the following settings and developer mode enabled:

settings.blocklistPattern = /(github\.dev|codesandbox\.io)/i;

I can't use VSCodeVim on github.dev, it behaves awkwardly. I'm not sure if this happens only to me, but the only workaround I've found is to disable this extension.

@clarkwang
Copy link
Author

Is this issue really fixed?

It works for me. I have something like this:

settings.blocklistPattern = new RegExp('^https://(calendar|docs|drive|keep).google.com');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests