Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for latest dbt_utils #190

Closed
NiallRees opened this issue Aug 31, 2022 · 6 comments
Closed

Add support for latest dbt_utils #190

NiallRees opened this issue Aug 31, 2022 · 6 comments

Comments

@NiallRees
Copy link
Contributor

We currently only support dbt_utils < 0.9.0

https://github.com/dbt-labs/dbt-utils/releases

@juls858
Copy link

juls858 commented Aug 31, 2022

this is preventing me from installing use dbt deps as it fails with a version error

@jaypeedevlin
Copy link
Contributor

jaypeedevlin commented Sep 1, 2022

@NiallRees to address this properly probably involves moving the instances of dbt_utils.split_part() to the cross db macros in dbt >=1.2, what do you think about me making this change as part of #188?

Bumping the deps version by itself gives us a bunch of deprecation warnings on that macro that I guess we want to avoid?

@jaypeedevlin
Copy link
Contributor

Alternate idea — now that split_part lives outside of utils, maybe we copy the SK implementation into our project and remove the dependency altogether?

@NiallRees
Copy link
Contributor Author

No strong opinions @jaypeedevlin happy for you to decide - might as well include in your PR though for sure

@jaypeedevlin
Copy link
Contributor

For posterity I decided to remove the dependency altogether.

@jaypeedevlin
Copy link
Contributor

This is resolved in 188 which should be released in the next week or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants