-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please document reason for fork #92
Comments
Re #91. |
I'm at work now, but I will answer your questions when I'm home and add it to the readme. |
I will provide some background to this situation. About two years ago I started adding some features that I wanted to be in rust-mode(rust-lang/rust-mode#255). Unfortunately rust-mode doesn't have active maintainers for quite a while so it was difficult to get pull requests merged, that were bigger than some lines of code. At some point I was kind of frustrated and somebody, I think it was actually you @tarsius, told me he took over maintainership for a package(I really think it was you, so magit^^) because there was no maintainer. So I decided to give it a try and created a pull request on melpa. Half a year ago I suggested to also maintain rust-mode (rust-lang/rust-mode#317). The result was that @mookid and I decided to give it a try. I leave out the details because you can read it in the issue. We discussed how to proceed, via mail. The idea was what you actually mentioned in 4). Due to a lack of time we didn't make those changes. Actually, I rather wanted to spend my time on projects like remacs and lsp-mode etc., because I thought this was more valuable. And this is still my opinion. I would very much appreciate pull requests or give write access to others, but I won't spend time on this any time soon. So the answers to your questions would be:
|
After reading this and rust-lang/rust-mode#317 I think the consensus is that we should avoid code-duplication, that getting there will be a lot of work, and that there will be complications. 😉 I will try to help out but keep in mind that I am a beginner and that my priorities lay elsewhere too. Before we can even tackle reconsolidating the two packages in one form or another, I think we first need to cleanup Expect pull-requests that fix these errors and do other cleanup shortly. |
Sounds great =) |
I ended up not really learning rust last year, but I just picked up the book again... |
I am just getting started with Rust and am trying to determine whether to use
rust-mode
orrustic
. From the look of it, it will take quite some time to make an informed choice so I decided to ask you for some clarification to save myself and others in the same position part of the effort.Your readme mentions some features that
rustic
has butrust-mode
lacks. That's a nice start but many questions come immediately to mind that are not addressed by a simple list of features, such as:rust-mode
still lack those features?rust-mode
improvements torustic
? Other way around?rust-mode.el
? Couldn't you have contributed to that in the upstream repository and makerustic
depend on that?rustic
into multiple smaller packages? I had to install quite a few dependencies that I am not actually going to use just so I could compile.Errr.... I just saw that you commented on the issue tracker of the
rust-mode
repository.That leaves me more confused than before, but also more hopeful.
The text was updated successfully, but these errors were encountered: