Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does phase change during runtime? #131

Open
cpaniaguam opened this issue Dec 9, 2022 · 0 comments
Open

Does phase change during runtime? #131

cpaniaguam opened this issue Dec 9, 2022 · 0 comments
Assignees

Comments

@cpaniaguam
Copy link
Member

The behavior of odeChamber and affect! (also build_matrix) depend on phase.

If phase does not change in runtime, checking its value is unnecessary. It seems like phase can be mutated by the IC_Finder_Functions in affect!

Consider creating a type for phase to create specialized versions of these functions in the same fashion as with the composition types.

https://github.com/CallieHsu/Chamber.jl/blob/d23788915ec9fea800ccb90b62f5e0a87db3c27c/src/runCode-func.jl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants