-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't forward parent when getting artist radio #1211
Conversation
Reviewer's Guide by SourceryThis PR fixes a bug related to parent-child relationships in artist radio functionality. The implementation adds a new No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tdambrin - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1211 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 20 20
Lines 723 723
Branches 46 46
=======================================
Hits 722 722
Partials 1 1 ☔ View full report in Codecov by Sentry. |
8e6d181
to
9fc7d64
Compare
Thanks! Nice fix |
@all-contributors please add @tdambrin for bug |
I've put up a pull request to add @tdambrin! 🎉 |
Fixes #1210
Description of change
Pull-Request Checklist
main
branchFixes #0000
(replace0000
with the actual issue number)Summary by Sourcery
Fix the bug where the artist radio incorrectly forwards the parent artist by introducing a fwd_parent parameter in the get_relation method and setting it to false for artist radio. Update tests to ensure tracks are from different artists.
Bug Fixes:
Tests: