Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write .env file as part of oauth script #386

Closed
browniebroke opened this issue Oct 10, 2021 · 6 comments · Fixed by #389
Closed

Write .env file as part of oauth script #386

browniebroke opened this issue Oct 10, 2021 · 6 comments · Fixed by #389
Labels
good first issue Good for newcomers hacktoberfest Good issues for Hacktoberfest

Comments

@browniebroke
Copy link
Owner

browniebroke commented Oct 10, 2021 •
edited
Loading

The recently added oauth.py script takes you through the OAuth flow to obtain an access token that can be used for development.

At the end, the token needs to be copied manually from the browser window to the .env file, but actually, the script could do it out of the box.

The contributing guide will need to be updated accordingly.
@browniebroke browniebroke added good first issue Good for newcomers hacktoberfest Good issues for Hacktoberfest labels Oct 10, 2021
@Carababusha
Copy link
Contributor

Hi @browniebroke! I'd love to take a look at this and help out.

@browniebroke
Copy link
Owner Author

Go ahead!

@Carababusha
Copy link
Contributor

Fantastic! I'll have a crack at it, then 😊

@Carababusha
Copy link
Contributor

I've had a go at it @browniebroke , does this look like the right way of doing it? I wasn't quite sure which .env file it was writing to https://github.com/Carababusha/deezer-python/blob/%23386-tokeninenv/oauth.py

@browniebroke
Copy link
Owner Author

Yes, that's a great start! Could you please open a pull request? There are a few minor things I would like to suggest, but it's nearly there 😄

Thanks again for taking the time to do that!

@Carababusha Carababusha mentioned this issue Oct 12, 2021
Merged
@Carababusha
Copy link
Contributor

Great! Just created the PR 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers hacktoberfest Good issues for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: write token to .env file in oauth script Carababusha/deezer-python
2 participants
@browniebroke @Carababusha