Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fetch resource if accessing missing field on simplified instance #541

Merged
merged 2 commits into from
Jul 25, 2022

Conversation

browniebroke
Copy link
Owner

@browniebroke browniebroke commented Jul 25, 2022

  • Include tests for bug fix and new functionality
  • Updated documentation for new feature

Fix #424
Fix #536

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 25, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 1.08%.

Quality metrics Before After Change
Complexity 4.12 ⭐ 3.26 ⭐ -0.86 👍
Method Length 36.62 ⭐ 37.67 ⭐ 1.05 👎
Working memory 6.47 🙂 6.52 🙂 0.05 👎
Quality 79.82% 80.90% 1.08% 👍
Other metrics Before After Change
Lines 71 116 45
Changed files Quality Before Quality After Quality Change
src/deezer/resources/resource.py 77.09% ⭐ 77.65% ⭐ 0.56% 👍
tests/resources/test_resource.py 95.68% ⭐ 91.17% ⭐ -4.51% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #541 (b69a84d) into main (49ac724) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #541   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          584       598   +14     
  Branches        62        64    +2     
=========================================
+ Hits           584       598   +14     
Impacted Files Coverage Δ
src/deezer/resources/resource.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@browniebroke browniebroke force-pushed the feat/refetch-on-attribute-error branch from c9c3839 to 233c41f Compare July 25, 2022 23:09
@browniebroke browniebroke changed the title feat: fetch resource if accessing missing field on shallow instance feat: fetch resource if accessing missing field on simplified instance Jul 25, 2022
@browniebroke browniebroke force-pushed the feat/refetch-on-attribute-error branch from 233c41f to b69a84d Compare July 25, 2022 23:20
@browniebroke browniebroke merged commit df5e81b into main Jul 25, 2022
@browniebroke browniebroke deleted the feat/refetch-on-attribute-error branch July 25, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant