Skip to content

Commit 80ab0d8

Browse files
committed
[New] add new core modules that will be in node v15
- `dns/promises`: nodejs/node#32953 - `assert/strict`: nodejs/node#34001 - `stream/promises`: nodejs/node#33991 - `timers/promises`: nodejs/node#33950
1 parent 46cafa1 commit 80ab0d8

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

lib/core.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ function specifierIncluded(specifier) {
66
var versionParts = (parts.length > 1 ? parts[1] : parts[0]).split('.');
77

88
for (var i = 0; i < 3; ++i) {
9-
var cur = Number(current[i] || 0);
10-
var ver = Number(versionParts[i] || 0);
9+
var cur = parseInt(current[i] || 0, 10);
10+
var ver = parseInt(versionParts[i] || 0, 10);
1111
if (cur === ver) {
1212
continue; // eslint-disable-line no-restricted-syntax, no-continue
1313
}

lib/core.json

+4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"assert": true,
3+
"assert/strict": ">= 15",
34
"async_hooks": ">= 8",
45
"buffer_ieee754": "< 0.9.7",
56
"buffer": true,
@@ -12,6 +13,7 @@
1213
"_debugger": "< 8",
1314
"dgram": true,
1415
"dns": true,
16+
"dns/promises": ">= 15",
1517
"domain": true,
1618
"events": true,
1719
"freelist": "< 6",
@@ -49,9 +51,11 @@
4951
"_stream_readable": ">= 0.9.4",
5052
"_stream_writable": ">= 0.9.4",
5153
"stream": true,
54+
"stream/promises": ">= 15",
5255
"string_decoder": true,
5356
"sys": true,
5457
"timers": true,
58+
"timers/promises": ">= 15",
5559
"_tls_common": ">= 0.11.13",
5660
"_tls_legacy": ">= 0.11.3 && < 10",
5761
"_tls_wrap": ">= 0.11.3",

test/core.js

+4-8
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,12 @@ test('core modules', function (t) {
2222

2323
for (var i = 0; i < cores.length; ++i) {
2424
var mod = cores[i];
25+
var requireFunc = function () { require(mod); }; // eslint-disable-line no-loop-func
26+
console.log(mod, resolve.core, resolve.core[mod]);
2527
if (resolve.core[mod]) {
26-
st.doesNotThrow(
27-
function () { require(mod); }, // eslint-disable-line no-loop-func
28-
mod + ' supported; requiring does not throw'
29-
);
28+
st.doesNotThrow(requireFunc, mod + ' supported; requiring does not throw');
3029
} else {
31-
st.throws(
32-
function () { require(mod); }, // eslint-disable-line no-loop-func
33-
mod + ' not supported; requiring throws'
34-
);
30+
st.throws(requireFunc, mod + ' not supported; requiring throws');
3531
}
3632
}
3733

0 commit comments

Comments
 (0)