Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timers-browserify dependency on setimmediate pollutes global environment #36

Open
rjgotten opened this issue Aug 30, 2018 · 1 comment

Comments

@rjgotten
Copy link

timers-browserify depends on setimmediate to make available setImmediate and clearImmediate functions.

This breaks proper encapsulation in Webpack builds where we don't want to pollute the global environment with polyfills. E.g. when authoring drop-in widgets for use within someone else's website and acting as a third-party.

@jryans
Copy link
Member

jryans commented Aug 30, 2018

Thanks for the feedback! Feel free to propose a fix via PR... From past experience, someone somewhere seems to depend on subtle details of the current implementation, so I can't make any guarantees that a change would stick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants