Skip to content
This repository has been archived by the owner on May 27, 2019. It is now read-only.

Support brave browser with install.sh #294

Closed
mithodin opened this issue Oct 23, 2018 · 3 comments
Closed

Support brave browser with install.sh #294

mithodin opened this issue Oct 23, 2018 · 3 comments

Comments

@mithodin
Copy link

The brave browser (https://brave.com/) now supports chrome extensions in the beta release channel and will apparently also support them in the stable release once it hits 1.0.

That means it also supports browserpass (yay!).

Therefore, the install script should try to detect brave and give the option to install the native messaging host json file in the appropriate location. So far, I have only been able to find the system-wide folder it looks at via brave/muon#259, but there should be an appropriate user location as well. If I manange to find out, I will update this issue.

@mithodin
Copy link
Author

With the beta version of brave, ~/.config/BraveSoftware/Brave-Browser-Beta seems to be the user path in linux.

@mithodin
Copy link
Author

I have created a pull request implementing this. #295

@maximbaz
Copy link
Member

Thanks for the PR, let's track this work via #295 then 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants