New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replaceState removes first character of hash (#) when it contains dot "." #477

Open

romangazarek opened this issue Dec 20, 2017 · 0 comments

romangazarek commented Dec 20, 2017 •

edited

Loading

Go to this demo URL:
http://browserstate.github.io/history.js/demo/#hash.with.dots

it is modified to:
http://browserstate.github.io/history.js/demo/hash.with.dots

Line of code:

history.js/scripts/uncompressed/history.js

Line 1703 in d213d8c

    
           History.replaceState(currentState.data, currentState.title, currentState.url, false);

Third argument currentState.url contains bad URL

Nachtalb mentioned this issue

Fix location hash with dot removes location hash 4teamwork/ftw.solr#178

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment