Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Tab overflow handling for many tabs #50

Open
MCMicS opened this issue Feb 23, 2018 · 8 comments
Open

Tab overflow handling for many tabs #50

MCMicS opened this issue Feb 23, 2018 · 8 comments

Comments

@MCMicS
Copy link
Contributor

MCMicS commented Feb 23, 2018

It would be nice to have a logic for many opened tabs.

possible solutions are:

  • arrow on the right side with a menu to show additional tabs
  • scrolling throught tabs like in Firefox

I have attached an image to show current behaviour

overflowtabs

@brrd
Copy link
Owner

brrd commented Feb 23, 2018

Related to #40.

@MCMicS
Copy link
Contributor Author

MCMicS commented Mar 20, 2018

Which variant do you prefer to implemnt. The scrolling or the wit additional button?
I can help with implementation

@brrd
Copy link
Owner

brrd commented Mar 20, 2018

Actually for the next major release I was planning to move to another existing CSS tabs library, such as https://github.com/adamschwartz/chrome-tabs. This is the main reason why I didn't work on this issue.

I already worked a bit in order to make chrome-tabs compliant with electron-tabs needs. Unfortunately I really lack time to go on right now and I will be very busy with my job during the next weeks/months.

If you still want to help, your contribution can be really useful until we move to chrome-tabs (or another similar solution). I don't know which solution is the best between scrolling or additional buttons, feel free to do it the way you prefer. It will be a great improvement anyway 😉

Thank you for your contribution! (I'll check your PR ASAP)

@MCMicS
Copy link
Contributor Author

MCMicS commented Mar 20, 2018 via email

@Skybeatzz
Copy link

I encountered this problem aswell and found a solution which isnt the best but works fine for me. I just changed 2 rows in your CSS and now i am able to scroll vertically if i get an overflow. The srollbar only appears when the overflow is happening.
I changed:
At "etabs-tabgroup" i added overflow: overlay;
At "etabs-tab" i changed padding: 6px 8px 4px; to padding: 5px 8px 4px;
The 2nd change is cause of the border the etabs-tab have. with it they reach a height of 33px and cause of the etabs-tabgroup is only 32px height, the scrollbar would appear everytime what i didnt liked.
I added a image how it looked now, if the overflow appears at my app.
electron-tabs_fix
Maybe this small "work around" will help some people :)

@midnight1994
Copy link

Is there a solution for this problem now?

@eddy5885
Copy link

eddy5885 commented Apr 14, 2023

Actually for the next major release I was planning to move to another existing CSS tabs library, such as https://github.com/adamschwartz/chrome-tabs. This is the main reason why I didn't work on this issue.

I already worked a bit in order to make chrome-tabs compliant with electron-tabs needs. Unfortunately I really lack time to go on right now and I will be very busy with my job during the next weeks/months.

If you still want to help, your contribution can be really useful until we move to chrome-tabs (or another similar solution). I don't know which solution is the best between scrolling or additional buttons, feel free to do it the way you prefer. It will be a great improvement anyway 😉

Thank you for your contribution! (I'll check your PR ASAP)

I can help you to finish it if you need.

We can add a parameter to allow users to choose whether to have a single line flexible compressed menu or to keep the current multi-line mode.

@brrd
Copy link
Owner

brrd commented Apr 14, 2023

I can help you to finish it if you need.

Thanks but I wrote this five years ago. Meanwhile I refactored the whole thing in a different way, so I'm not planning to use chrome-tabs anymore. You still can customize the styles to mimic chrome styles if you want, but it won't be merged into this project IMO.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants