-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The build is slow #28
Comments
Ok I did some reasearch and here's what I found:
Some options for solving 2 include:
In short, it looks like my options right now are switch back from SASS to CSS, or undo my some of my performance tweaks. 😞 |
Just an idea: I might be able to use Jekyll Hooks to find a time during the build lifecycle after my Also, with a different approach I might not need to source it from |
Update: the SCSS compiling performance will improve when updating to to Jekyll 4 (because it uses Alternatively, I could move away from using |
Update: I checked the analytics again, and the % of visitors using browsers that don't support CSS Custom Properties has dropped to less than 2.5%. That makes me feel better about switching away from Sass to CSS. |
Here's the profiling after some fixes: Original Build (done in 68.763 seconds).
Switching from SCSS to CSS (done in 13.698 seconds).
Switching to CSS and removing HTML compression (done in 7.811 seconds):
Yeah, this is a pretty huge improvement, and it should have minimal effect on the end-user. The only additional user cost is that the SASS comments are no longer stripped out, and the html isn't compressed. The more I've research html compression, the more I feel like it's not really worth it, especially after gzipping. |
So slow.
I'm pretty sure it's because of this code here. I'm thinking the big O complexity isn't very favorable.
I still want to be able to do related articles, so if there's a way to optimize these loops without changing how related articles work, that would be ideal. If we need to, we can change how related articles are formatted in the metadata.
The text was updated successfully, but these errors were encountered: