Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle individual verses in references #8

Open
bryanforbes opened this issue Oct 2, 2017 · 2 comments
Open

Handle individual verses in references #8

bryanforbes opened this issue Oct 2, 2017 · 2 comments

Comments

@bryanforbes
Copy link
Owner

Currently, references like John 19:13, 17, 20 aren't recognized. The verse parser should be updated to handle this.

@hypirae
Copy link

hypirae commented Jul 21, 2019

I took a look into this issue and ended up rewriting the entire verse parser in a less... RegEx heavy way. In doing so I took some liberty with how the whole thing works and the assumption I made is that it would be grabbing implicit verse references from the text. However, it is fairly simple in structure and really could be fairly easily adapted into the code of the bot.

https://gist.github.com/Hypirae/c2815d98b5a31f547f07297d508d8d6b

@hypirae
Copy link

hypirae commented Jan 1, 2022

I don't know if you ever saw this but I think that it is still a patch worth looking into just for the ease of quoting multiple sections from the same chapter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants