Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getter/Setters sorted into methods #54

Open
Fuzzyma opened this issue May 11, 2020 · 1 comment
Open

Getter/Setters sorted into methods #54

Fuzzyma opened this issue May 11, 2020 · 1 comment

Comments

@Fuzzyma
Copy link

Fuzzyma commented May 11, 2020

It looks like accessors are not correctly put into the accesor group.
My config looks like this:

      "order": [
        "[static-properties]",
        "[properties]",
        "[conventional-private-properties]",
        "constructor",
        "[static-methods]",
        "[methods]",
        "[conventional-private-methods]",
        "[accessor-pairs]",
        "[getters]",
        "[setters]",
        "[everything-else]"
      ],

It looks really great only that the accessors are just handled as a method. So a getter with name "baz" comes between method "bar" and "foo". That seems wrong since I explicitely want the getters behind the methods.

PS: I updated all standard groups with sort: alphabetical but removing this didnt lead to eslint complaining either. So it seems to have nothing to do with my customised groups

// EDIT: It sometimes works when I put the getter back in place after initial sorting but sometimes it complains about wrong ordering in accessors then without fixing it and sometimes it puts it back into the methods - really strange

@dospunk
Copy link
Contributor

dospunk commented Apr 19, 2023

This might be because kind and type have the same value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants