Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Strategy pattern interface for unicode string comparator #5

Open
Wang-Yue opened this issue Jun 5, 2016 · 0 comments
Open

Comments

@Wang-Yue
Copy link

Wang-Yue commented Jun 5, 2016

Right now Pinyin comparator is hooked into the internal implementation of the player ui. It's better to have a Strategy pattern interface for this purpose. A factory object can generate user defined comparator.

The comparators themselves can be standalone plugins that's hooked into your plugin framework.

Also it's not a good idea to have a huge pinyin table that's built into the player binary. Usually it's done by linking the plugin itself to some i18n library (such as ICU).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant