Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about parallelize_loop #11

Closed
BenjaminChi007 opened this issue Jun 2, 2021 · 1 comment
Closed

Question about parallelize_loop #11

BenjaminChi007 opened this issue Jun 2, 2021 · 1 comment

Comments

@BenjaminChi007
Copy link

BenjaminChi007 commented Jun 2, 2021

Does "while (blocks_running != 0) in for loop scope" make block push_task not run parallelized? Thanks
image

@bshoshany
Copy link
Owner

bshoshany commented Jun 2, 2021

Yes, you are correct.

I copied this function from another library I wrote, where a similar function is used to parallelize matrix operations. I must have made a mistake when adapting the function to parallelize one loop instead of two. Since I did the benchmarks using the matrix parallelizer instead of the loop parallelizer, I never noticed this issue.

I will post a new release in a bit where this issue is fixed. Thank you so much for spotting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants