New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valid taproot signature may not must has length of 64 #122

Open

timqi opened this issue Dec 11, 2023 · 1 comment

timqi commented Dec 11, 2023

Describe the bug
It seems not right to check signature of taproot is valid by assert length of it equals 64:

btclib/btclib/psbt/psbt_utils.py

Line 307 in da0cfc1

if any(signature and len(signature) != 64 for signature in signatures):

To Reproduce
There is an example on how to make a valid taproot signature which length is not 64:
bitcoinjs/bitcoinjs-lib#1934

Environment (please complete the following information):

OS: ubuntu
Python version: 3.10.13
btclib version: da0cfc1 master 2023.12.12

The text was updated successfully, but these errors were encountered:

Author

timqi commented Dec 11, 2023

Will it support sign psbt from library?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment